[PATCH] D64096: [AMDGPU] Enable serializing of argument info.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 15:19:14 PDT 2019


arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

Can you avoid having an explicit isReg field? It should be able to infer if it's a register or stack offset



================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:129-132
+    if (IsRegister)
+      ::new ((void *)std::addressof(RegisterName))
+          StringValue(Other.RegisterName);
+    else
----------------
braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64096/new/

https://reviews.llvm.org/D64096





More information about the llvm-commits mailing list