[llvm] r364968 - [ThinLTO] Address post-review suggestions for index-based WPD summary
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 14:07:45 PDT 2019
Author: tejohnson
Date: Tue Jul 2 14:07:45 2019
New Revision: 364968
URL: http://llvm.org/viewvc/llvm-project?rev=364968&view=rev
Log:
[ThinLTO] Address post-review suggestions for index-based WPD summary
Removes a couple of unnecessary and/or redundant checks introduced by
r364960.
Modified:
llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
Modified: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=364968&r1=364967&r2=364968&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp (original)
+++ llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp Tue Jul 2 14:07:45 2019
@@ -3688,20 +3688,19 @@ void ModuleBitcodeWriterBase::writeModul
// been initialized from a DenseSet.
llvm::sort(NameVals.begin() + SizeBeforeRefs, NameVals.end());
- if (!VTableFuncs.empty()) {
+ if (VTableFuncs.empty())
+ Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
+ FSModRefsAbbrev);
+ else {
// VTableFuncs pairs should already be sorted by offset.
for (auto &P : VTableFuncs) {
NameVals.push_back(VE.getValueID(P.FuncVI.getValue()));
NameVals.push_back(P.VTableOffset);
}
- }
- if (VTableFuncs.empty())
- Stream.EmitRecord(bitc::FS_PERMODULE_GLOBALVAR_INIT_REFS, NameVals,
- FSModRefsAbbrev);
- else
Stream.EmitRecord(bitc::FS_PERMODULE_VTABLE_GLOBALVAR_INIT_REFS, NameVals,
FSModVTableRefsAbbrev);
+ }
NameVals.clear();
}
@@ -3854,14 +3853,12 @@ void ModuleBitcodeWriterBase::writePerMo
NameVals.clear();
}
- if (!Index->typeIdCompatibleVtableMap().empty()) {
- for (auto &S : Index->typeIdCompatibleVtableMap()) {
- writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
- S.second, VE);
- Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
- TypeIdCompatibleVtableAbbrev);
- NameVals.clear();
- }
+ for (auto &S : Index->typeIdCompatibleVtableMap()) {
+ writeTypeIdCompatibleVtableSummaryRecord(NameVals, StrtabBuilder, S.first,
+ S.second, VE);
+ Stream.EmitRecord(bitc::FS_TYPE_ID_METADATA, NameVals,
+ TypeIdCompatibleVtableAbbrev);
+ NameVals.clear();
}
Stream.ExitBlock();
More information about the llvm-commits
mailing list