[PATCH] D64096: [AMDGPU] Enable serializing of argument info.
Michael Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 13:50:24 PDT 2019
hliao marked an inline comment as done.
hliao added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:1082
+ // Check and apply the optional mask.
+ if (A->Mask)
+ Arg = ArgDescriptor::createArg(Arg, A->Mask.getValue());
----------------
rampitec wrote:
> Default mask value in ArgDescriptor is not 0, it is ~0.
Optional<unsigned> only return true when is assigned with values. It's not equivalent to the checking of 0.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64096/new/
https://reviews.llvm.org/D64096
More information about the llvm-commits
mailing list