[PATCH] D64036: [Bitcode] Update CHECK-DAG usage in tests

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Bitcode/upgrade-pointer-address-space.ll:3
 
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
-; CHECK-DAG: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
+; CHECK: !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}})
----------------
aprantl wrote:
> probinson wrote:
> > jdenny wrote:
> > > Ugh, sorry, there are two occurrences of the matching text, so we can have two `CHECK` directives.  `CHECK-DAG` does not appear useful.  Will fix.
> > I went back to the review that introduced this test (D29670) and I can't tell what is being tested here.  It looks like prior LLVM versions would have passed this test as well, so it is not exercising the patch at all.
> > @kzhuravl what was the intent of this test? Proving that the disassembly reports two arbitrary pointer types with unspecified characteristics does not seem very useful.
> IIUC, this is testing that the older bitcode format, without the address space field introduced in D29670, can be upgraded correctly.
Thanks.  I see older releases are also producing two pointer types so I guess that's sufficient, and Joel's conversion to two non-DAG CHECKs is correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64036/new/

https://reviews.llvm.org/D64036