[PATCH] D41585: [Greedy RegAlloc] Take into account the cost of local intervals when selecting split candidate.

[Teresa Johnson via llvm-commits]

On Tue, Jun 25, 2019 at 12:19 PM Quentin Colombet via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Nice catch Teresa!
>
> I think the flag is more intended for debug purposes. But given nobody
> noticed the typo for a while and that there is no test, let us get rid of
> it.
>

I decided to just fix the typo, in case it is useful for debugging at some
point.  r364958

Teresa


> Cheers,
> -Quentin
>
> > On Jun 25, 2019, at 9:39 AM, Teresa Johnson via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >
> > tejohnson added a comment.
> > Herald added a project: LLVM.
> >
> > I was looking at flags in this file and noticed there is a typo in the
> flag added here (condsider-local-interval-cost should be "consider-...",
> note the extraneous "d" in the flag). Also, there doesn't seem to be any
> test utilizing this flag. Should it be removed?
> >
> >
> > Repository:
> >  rL LLVM
> >
> > CHANGES SINCE LAST ACTION
> >  https://reviews.llvm.org/D41585/new/
> >
> > https://reviews.llvm.org/D41585
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190702/9e5c9b29/attachment.html>