[PATCH] D63785: Add support for MUSL libc

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 11:12:55 PDT 2019


kcc added a comment.

Frankly, I would like to see a parallel effort in Musl. 
I've seen the recent comment at https://github.com/google/sanitizers/issues/1080#issuecomment-506565699
suggesting that Musl is not likely to accept this approach.
But please look at the situation from our perspective: 
this amount of #ifdefs in the code will increase the cost of maintenance for us, w/o giving much to anyone who doesn't use Musl. 
And this is a wrong technical decision anyway, as we've known in 2011 (just didn't have other choice) 
and as we've confirmed with our current implementation of HWASAN in Bionic.

If you are enthusiastic about having sanitizers support Musl w/o changes in Musl, 
then the right way would be to move all Musl-specific code to Musl-specific files. 
This will be quite a bit of code duplication, but it won't put any burden on us.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63785/new/

https://reviews.llvm.org/D63785





More information about the llvm-commits mailing list