[PATCH] D64084: [AArch64][GlobalISel] Teach tryOptSelect to handle G_ICMP

[Jessica Paquette via Phabricator via llvm-commits]

paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2777
+                                    MachineIRBuilder &MIRBuilder) const {
+  assert(LHS.isReg() && RHS.isReg() && "Expected LHS and RHS to be registers!");
+  MachineRegisterInfo &MRI = MIRBuilder.getMF().getRegInfo();
----------------
aemerson wrote:
> Can we just make these emit interfaces use Register instead? It doesn't seem like we need the full generality of MachineOperand.
The only thing that makes that tricky, is that `selectArithImmed` takes a MachineOperand.

I guess that we could easily just compute it in `emitIntegerCompare` and pass the result along to this function though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64084/new/

https://reviews.llvm.org/D64084