[PATCH] D63444: [ThinLTO] Optimize write-only globals out
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 08:16:02 PDT 2019
tejohnson accepted this revision.
tejohnson added a comment.
LGTM with one minor comment nit below. Thanks!
================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:292
+ // non-store instruction. References from first operand of store
+ // (stored value) can't be treated neither as read- nor as write-only
+ // so we add them to RefEdges as we do with all other instructions
----------------
Avoid double negative by changing to "can't be treated either as read- or as write-only..."
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63444/new/
https://reviews.llvm.org/D63444
More information about the llvm-commits
mailing list