[PATCH] D64014: [Object/ELF.h] - Improve error reporting.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 07:47:10 PDT 2019


grimar added a comment.

In D64014#1565714 <https://reviews.llvm.org/D64014#1565714>, @jakehehrlich wrote:

> How important is using ErrSaver. Isn't it possible to just use std::string in these error cases?


I removed it. Honestly saying, I introduced it because for some reason was sure that `Error` keeps `StringRef` inside and not a `std::string`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64014/new/

https://reviews.llvm.org/D64014





More information about the llvm-commits mailing list