[PATCH] D64065: Skip test earlier if metric is not found in compare.py

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: utils/compare.py:37
             sys.stderr.write("Error: Multiple tests with name '%s'\n" % name)
             sys.exit(1)
         names.add(name)
----------------
serge-sans-paille wrote:
> I don't know if it's relevant, but a missing metrics *and* empty or duplicate name would no longer raise an Exception; it's probably better to `continue` right after the sanity checks?
Yep, it should be after the name validation, thanks


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64065/new/

https://reviews.llvm.org/D64065