[PATCH] D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable

[Luís Marques via Phabricator via llvm-commits]

luismarques added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp:189
+                                    unsigned Encoding) const {
+  if ((Encoding & 0x7) == dwarf::DW_EH_PE_uleb128)
+    EmitLabelDifferenceAsULEB128(Hi, Lo);
----------------
Regarding the `0x7` magic constant, it's not very clear in this context why that is the right value. Can we replace that with a symbolic constant, or at least add some context (a comment, etc.) to make it clear to readers the logic behind that value?


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp:197
+                                   unsigned Encoding) const {
+  if ((Encoding & 0x7) == dwarf::DW_EH_PE_uleb128)
+    EmitULEB128(Value);
----------------
Ditto magic constant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63415/new/

https://reviews.llvm.org/D63415