[PATCH] D63974: [ELF] Only allow the binding of SharedSymbol to change for the first undef ref

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: ELF/Symbols.h:370
+  // change to STB_WEAK if the first undefined reference is weak.
+  bool Referenced = false;
 };
----------------
ruiu wrote:
> Does this increase the size of the symbol?
sizeof(Defined) == 80
sizeof(SharedSymbol) == 80. `Alignment` occupied bytes [52,56). This was not obvious, so I reordered the fields to make it obvious.

sizeof(SharedSymbol) is still 80 after reordering.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63974/new/

https://reviews.llvm.org/D63974