[PATCH] D63764: [Sanitizers] Remove obsolete OpenFile from sanitizer_solaris.cc

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

Are you sure it's unused? I see several uses of this function:

lib$ grep OpenFile sanitizer_common/*.{h,cc} tsan/rtl/*.cc
sanitizer_common/sanitizer_file.h:fd_t OpenFile(const char *filename, FileAccessMode mode,
sanitizer_common/sanitizer_posix.h:// Don't use directly, use __sanitizer::OpenFile() instead.
sanitizer_common/sanitizer_coverage_libcdep_new.cc:static fd_t OpenFile(const char* path) {
sanitizer_common/sanitizer_coverage_libcdep_new.cc:  fd_t fd = OpenFile(path, WrOnly, &err);
sanitizer_common/sanitizer_coverage_libcdep_new.cc:  fd_t fd = OpenFile(file_path);
sanitizer_common/sanitizer_file.cc:  fd = OpenFile(full_path, WrOnly);
sanitizer_common/sanitizer_file.cc:    fd_t fd = OpenFile(file_name, RdOnly, errno_p);
sanitizer_common/sanitizer_file.cc:  fd_t fd = OpenFile(file_name, RdOnly, errno_p);
sanitizer_common/sanitizer_linux_libcdep.cc:  fd_t fd = OpenFile("/proc/self/statm", RdOnly);
sanitizer_common/sanitizer_posix.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *errno_p) {
sanitizer_common/sanitizer_posix.cc:  fd_t fd = OpenFile(file_name, RdOnly);
sanitizer_common/sanitizer_rtems.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *errno_p) {
sanitizer_common/sanitizer_solaris.cc:uptr OpenFile(const char *filename, bool write) {
sanitizer_common/sanitizer_win.cc:  fd_t fd = OpenFile(modname, RdOnly, nullptr);
sanitizer_common/sanitizer_win.cc:fd_t OpenFile(const char *filename, FileAccessMode mode, error_t *last_error) {
tsan/rtl/tsan_rtl.cc:      fd_t fd = OpenFile(filename.data(), WrOnly);


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63764/new/

https://reviews.llvm.org/D63764