[PATCH] D63804: [PowerPC] Implement the areMemAccessesTriviallyDisjoint hook
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 1 19:41:55 PDT 2019
steven.zhang marked an inline comment as done.
steven.zhang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:361
+
+ /// Return true if retrieve the base, offset from the base and width. Width
+ /// is the size of memory that is being loaded/stored (e.g. 1, 2, 4, 8).
----------------
jsji wrote:
> This is a little confusing to me, it is easy to read it as `retrieve ... from ...`.
> Maybe something like `get the base operand, byte offset of an instruction and the memory width`?
>
> There are 2-3 similar ones in PPCInstrInfo.cpp as well.
ok, I will update it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63804/new/
https://reviews.llvm.org/D63804
More information about the llvm-commits
mailing list