[PATCH] D64045: [InstrProfiling] Put instrumentation into comdat group with function

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:1055
+
+  // available_externally functions have their body elsewhere so ignore those.
+  if (F.getLinkage() == GlobalValue::AvailableExternallyLinkage)
----------------
See the comments in the code deleted by this patch. 

Here you reverse the logic. IIRC, it will greatly increase the size of the profile data as the counter and per function data for externally available symbols won't be commoned.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64045/new/

https://reviews.llvm.org/D64045