[PATCH] D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed]

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

We're getting link errors about operator delete in 32-bit builds:

  [197/771] Generating ScudoCUnitTest-i386-Test
  FAILED: projects/compiler-rt/lib/scudo/standalone/tests/ScudoCUnitTest-i386-Test 
  cd /b/swarming/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/lib/scudo/standalone/tests && /b/swarming/w/ir/cache/builder/src/third_party/llvm-bootstrap/./bin/clang ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o ScudoUnitTestsObjects.scudo_unit_test_main.cc.i386.o ScudoUnitTestsObjects.gtest-all.cc.i386.o /b/swarming/w/ir/cache/builder/src/third_party/llvm-bootstrap/lib/libRTScudoCUnitTest.i386.a -o /b/swarming/w/ir/cache/builder/src/third_party/llvm-bootstrap/projects/compiler-rt/lib/scudo/standalone/tests/./ScudoCUnitTest-i386-Test -fno-pie -Wl,-allow-shlib-undefined -lstdc++ -pthread -m32
  ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o: In function `__cxx_global_var_init.1':
  wrappers_c_test.cc:(.text.startup+0x17a): undefined reference to `operator delete(void*, unsigned int)'
  ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o: In function `__cxx_global_var_init.18':
  wrappers_c_test.cc:(.text.startup+0x2ea): undefined reference to `operator delete(void*, unsigned int)'
  ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o: In function `__cxx_global_var_init.24':
  wrappers_c_test.cc:(.text.startup+0x45a): undefined reference to `operator delete(void*, unsigned int)'
  ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o: In function `__cxx_global_var_init.33':
  wrappers_c_test.cc:(.text.startup+0x5ca): undefined reference to `operator delete(void*, unsigned int)'
  ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o: In function `__cxx_global_var_init.36':
  wrappers_c_test.cc:(.text.startup+0x73a): undefined reference to `operator delete(void*, unsigned int)'

It would be enough for us to exclude these tests from `check-all`, so rather than reverting, I might do that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63831/new/

https://reviews.llvm.org/D63831