[PATCH] D60974: Clang IFSO driver action.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 15:36:01 PDT 2019


plotfi added a comment.

In D60974#1565577 <https://reviews.llvm.org/D60974#1565577>, @jfb wrote:

> Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang?




In D60974#1565577 <https://reviews.llvm.org/D60974#1565577>, @jfb wrote:

> Looking at the code quickly, I'm not sure that this should be in clang itself. It sounds like a better fit for a clang-based tool, and not clang. Why does it need to be part of clang?


@jfb Having interface stubs generated by clang itself makes sense because we want to use the same clang invocation (with the addition of -emit-interface-stubs) to be what generates the stubs so that everything is fully consistent with what -fvisibility/__attribute__ visibility would have exposed in a normal non-stub build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974





More information about the llvm-commits mailing list