[PATCH] D63570: [COFF] Implement /safeseh:no and check @feat.00 flags by default
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 1 14:25:41 PDT 2019
mstorsjo requested changes to this revision.
mstorsjo added inline comments.
This revision now requires changes to proceed.
================
Comment at: lld/COFF/Driver.cpp:1537
+ if (Config->Machine == I386 &&
+ Args.hasFlag(OPT_safeseh, OPT_safeseh_no, true))
+ Config->SafeSEH = true;
----------------
mstorsjo wrote:
> Should the default be off in the mingw case, if linking objects from gcc?
I tested this patch now, and indeed, either the default needs to be different if `Config->MinGW` is true, or the MinGW driver needs to pass `-safeseh:no` by default.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63570/new/
https://reviews.llvm.org/D63570
More information about the llvm-commits
mailing list