[PATCH] D60613: Make setInitializer() assert that the entire initializer is usable.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 11:29:31 PDT 2019


efriedma added inline comments.


================
Comment at: llvm/unittests/IR/VerifierTest.cpp:228
+  // reference.
+  auto GV1again = ConstantExpr::getPointerCast(GV1, GV1->getType());
+  new GlobalVariable(M2, ST, true, GlobalVariable::ExternalLinkage,
----------------
Are you sure this actually does what you want?  ConstantExpr::get() does basic constant folding.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60613/new/

https://reviews.llvm.org/D60613





More information about the llvm-commits mailing list