[PATCH] D31359: [GlobalISel]: Allow backends to custom legalize Intrinsics

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 10:23:30 PDT 2019


aditya_nandakumar added a comment.

In D31359#1564825 <https://reviews.llvm.org/D31359#1564825>, @arsenm wrote:

> LGTM. I have a few patches depending on this now, and returning the bool is good enough. I think refining the result may be useful, but I haven't run into a concrete need for it yet. It would be more useful if we had a mechanism for detecting whether an intrinsic is legal or not, so that the selector verifier could error like any other instruction.


Thanks. I think for now it's important to get this patch in - considering how l long it's been open :). I agree it would be nice to have a mechanism to detect legality of intrinsics - but that's for another commit I think.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31359/new/

https://reviews.llvm.org/D31359





More information about the llvm-commits mailing list