[PATCH] D63521: Teach the symbolizer lib symbolize objects directly.

Mon Jul 1 10:04:43 PDT 2019

ychen added a comment.

In D63521#1563367 <https://reviews.llvm.org/D63521#1563367>, @MaskRay wrote:

> In D63521#1562497 <https://reviews.llvm.org/D63521#1562497>, @ychen wrote:
>
> > Hi @MaskRay, from @rnk 's inputs, seems this is not a common case worth pursuing at least for the moment, is it ok to move forward with the first choice I described?
>
>
> My comment on your first version of this patch is about the potential code duplication. Now the codeview concern of the code duplication has been addressed.
>
> The current version doesn't look bad to me. Do you think the initial version is better?

The expected client for this new `symbolizeCode` interface is for archive members and COFF is unlikely to symbolize plain object files for the moment.
I think the concern here the code movement for removing the potential duplication puts some untested code in the path for DWARF. I assume if there is a need for the COFF archive member symbolization we could easily deduplicate the code in the patch for COFF?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63521/new/

https://reviews.llvm.org/D63521