[PATCH] D63671: [llvm-profdata] Avoid keeping reference to every files

Mon Jul 1 09:46:03 PDT 2019

paulsemel added a comment.

In D63671#1563092 <https://reviews.llvm.org/D63671#1563092>, @wmi wrote:

> In D63671#1556584 <https://reviews.llvm.org/D63671#1556584>, @paulsemel wrote:
>
> > Add one test case.
>
>
> Thanks. If we remove the code to replace string reference from file data buffer to FunctionNames set for call targets, will the test fail?

No, because this change is kind of a NFC, which implies that I want to keep the same behaviors as previously.
To actually have a test that fails if we remove this code, we would need to have a super heavy and time consuming test, which is, imo, not what we want for a test.

Do we really need to have a tests that fails if we remove this code ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63671/new/

https://reviews.llvm.org/D63671