[PATCH] D60528: [RISCV] Diagnose invalid second input register operand when using %tprel_add

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/trunk/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1701
+    if (checkPseudoAddTPRel(Inst, Operands))
+      return true;
   }
----------------
jrtc27 wrote:
> This is rather nasty, as it currently implicitly falls through to the end of the switch block rather than with an explicit `break`, so any new cases need to either come before this one or add the `break` in. Could you please add the `break` in a follow-up commit?
Done in r364746.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60528/new/

https://reviews.llvm.org/D60528