[PATCH] D62718: [llvm-objcopy] Change handling of output file permissions

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM. @MaskRay should approve before this gets committed though.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test:4
+
+## Unix version of this test must use umask(1)
+## or tests might fail.
----------------
abrachet wrote:
> jhenderson wrote:
> > You could probably combine this comment paragraph with the initial one.
> > You could probably combine this comment paragraph with the initial one.
> I separated these because the initial one is explaining the entire test but the second comment is explaining the  `# UNSUPPORTED: system-windows`. Do you still think I should combine them, I don't have a large preference.
This is fine now. The extra detail makes it a more meaningful independent paragraph.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718