[PATCH] D63884: [ARM] MVE VMOV immediate handling

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me, some nits inline.



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:5968
+    // cmode == 0b1101 is not supported for MVE VMVN
+    if (type == MveVMVNModImm)
+      return SDValue();
----------------
nit: Mve -> MVE?


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.h:824
     VMVNModImm,
+    MveVMVNModImm,
     OtherModImm
----------------
nit: don't know, perhaps Mve -> MVE for consistency.


================
Comment at: llvm/test/CodeGen/Thumb2/mve-vmovimm.ll:4
+; RUN: llc -mtriple=thumbv8.1m.main-arm-none-eabi -mattr=+mve.fp -verify-machineinstrs %s -o - | FileCheck %s
+
+define arm_aapcs_vfpcc <16 x i8> @mov_int8_1() {
----------------
is it useful to test this with `-mattr=-mve` too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63884/new/

https://reviews.llvm.org/D63884