[PATCH] D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 29 19:54:08 PDT 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUGISel.td:132
+def : GISelSop2Pat <add, S_ADD_I32, i32>;
+def : GISelVop2Pat <add, V_ADD_I32_e32, i32>;
+
----------------
arsenm wrote:
> Should use the _e64 version
I tried to do this, but there are a few problems. I have a supplemental patch which uses the right version for gfx9.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58804/new/

https://reviews.llvm.org/D58804





More information about the llvm-commits mailing list