[compiler-rt] r364700 - [TSan] Attempt to fix linker error for Linux on AArch64

[via llvm-commits]

Hi Julian,

Your change is causing a build failure on the sanitizer bot, can you take a look?

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22113/steps/check-tsan%20in%20gcc%20build/logs/stdio

/tmp/gotsan.JfrpVPu7pG/gotsan.cc:10456:25: error: ‘_tsan_pointer_chk_guard’ initialized and declared ‘extern’ [-Werror]
 extern "C" __tsan::uptr _tsan_pointer_chk_guard = 0;
                         ^~~~~~~~~~~~~~~~~~~~~~~

Douglas Yung

-----Original Message-----
From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of Julian Lettner via llvm-commits
Sent: Friday, June 28, 2019 17:41
To: llvm-commits at lists.llvm.org
Subject: [compiler-rt] r364700 - [TSan] Attempt to fix linker error for Linux on AArch64

Author: yln
Date: Fri Jun 28 17:40:45 2019
New Revision: 364700

URL: http://llvm.org/viewvc/llvm-project?rev=364700&view=rev
Log:
[TSan] Attempt to fix linker error for Linux on AArch64

Introduced in 5be69ebe121d5b6ea284c3dc6d1cd5098c94f353.

Modified:
    compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc
    compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_aarch64.S

Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc?rev=364700&r1=364699&r2=364700&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc (original)
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_platform_linux.cc Fri Jun 28 
+++ 17:40:45 2019
@@ -69,8 +69,9 @@ void *__libc_stack_end = 0;
 
 #if SANITIZER_LINUX && defined(__aarch64__)  void InitializeGuardPtr() __attribute__((visibility("hidden")));
-extern "C" __tsan::uptr _tsan_pointer_chk_guard;  #endif
+// TODO(yln): only define this when necessary extern "C" __tsan::uptr 
+_tsan_pointer_chk_guard = 0;
 
 namespace __tsan {
 

Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_aarch64.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_aarch64.S?rev=364700&r1=364699&r2=364700&view=diff
==============================================================================
--- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_aarch64.S (original)
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_aarch64.S Fri Jun 28 
+++ 17:40:45 2019
@@ -3,14 +3,6 @@
 
 #include "sanitizer_common/sanitizer_asm.h"
 
-#if !defined(__APPLE__)
-.section .bss
-.type	__tsan_pointer_chk_guard, %object
-ASM_SIZE(ASM_SYMBOL_INTERCEPTOR(__tsan_pointer_chk_guard))
-__tsan_pointer_chk_guard:
-.zero	8
-#endif
-
 #if defined(__APPLE__)
 .align  2
 


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits