[PATCH] D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:66
+
+  // TODO FIXME Finialize symbols.
+
----------------
Typo: s/Finialize/Finalize/;


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:232
 
+  class XCOFFPPCAsmBackend : public PPCAsmBackend {
+  public:
----------------
The starting indentation level does not match that of the preceding class.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:161
 
+  class PPCAIXAsmPrinter : public PPCAsmPrinter {
+  public:
----------------
See previous comment about the starting indentation level.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-basic.ll:31
+
+; ASM: .csect .text[PR]
----------------
hubert.reinterpretcast wrote:
> I would prefer to have a comment to the effect that the csect need not be present, but we generate it anyway.
Note that, at least in the current status of this patch, the assembly output and the object output from LLVM do not describe the same abstract XCOFF content.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61694/new/

https://reviews.llvm.org/D61694