[PATCH] D63885: [LOOPINFO] Introduce the loop guard API.

[Ettore Tiotto via Phabricator via llvm-commits]

etiotto added a comment.

In D63885#1563442 <https://reviews.llvm.org/D63885#1563442>, @Whitney wrote:

> @reames Thanks for the review! I agree that there are still much more to consider for how we want to define a loop guard, to make the most use of it.
>
> What's others opinion on disallow instructions with side effects in between the loop guard block and the loop header?


My opinion is that we should extend the proposed API to identify 'proper' loop guards. A proper loop guard would protect the execution of the loop and nothing else. So it would not allow any instruction with side effects between the guard and the loop header, or other weak guards.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63885/new/

https://reviews.llvm.org/D63885