[PATCH] D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

The high-level plan (limit the amount of movement done in placeDbgValues, check for any fallout, and (hopefully) eventually eliminate all of it) sgtm.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:7126
   bool MadeChange = false;
+  DominatorTree DT(F);
+
----------------
Use CGP::getDT()?


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:7135
 
       Instruction *VI = dyn_cast_or_null<Instruction>(DVI->getValue());
+
----------------
Early exit on !VI for clarity?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58453/new/

https://reviews.llvm.org/D58453