[PATCH] D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs

[Pengfei Wang via Phabricator via llvm-commits]

pengfei marked 4 inline comments as done.
pengfei added a comment.

Thanks for the review



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:2245
+    if (MBB.isEHFuncletEntry() && STI.is64Bit()) {
+      if (X86::FR64RegClass.contains(Reg)) {
+        int Offset = (CSI[i].getFrameIdx() - XMMFrameSlotOrigin - 1) * 16;
----------------
craig.topper wrote:
> Any reason we're using FR64 here instead of VR128?
VR128 should be more accurate. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63396/new/

https://reviews.llvm.org/D63396