[PATCH] D63155: [clang][NewPM] Fix broken profile test

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 17:21:13 PDT 2019


chandlerc added a comment.

In D63155#1563275 <https://reviews.llvm.org/D63155#1563275>, @xur wrote:

> In D63155#1563266 <https://reviews.llvm.org/D63155#1563266>, @chandlerc wrote:
>
> > I just think we also need to understand why *no other test failed*, and why the only test we have for doing PGO at O0 is this one and it could be "fixed" but such a deeply unrelated change....
>
>
> We have special code to do PGO at O0 in old pass manager. This is not done in the new pass manager.


I'm not sure how this addresses my question about test coverage.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63155/new/

https://reviews.llvm.org/D63155





More information about the llvm-commits mailing list