[PATCH] D63243: [WIP] Adjust the users of dereferenceable wrt. dereferenceable_globally
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 16:37:53 PDT 2019
reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.
Happy to talk offline (call, chat, etc..) since we seem to be talking past each other again.
================
Comment at: llvm/lib/IR/Value.cpp:689
DerefBytes = CI->getLimitedValue();
+ DerefKnownBefore = LI->getNextNode();
}
----------------
Same point as before, but explained differently in the hopes this makes sense.
DerefKnownBefore only ever takes one of two values: the first instruction within the function, or the one after the instruction we invoked this function on. As such, the return value adds no information which can't be easily determined from a single boolean.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63243/new/
https://reviews.llvm.org/D63243
More information about the llvm-commits
mailing list