[PATCH] D63959: [WebAssembly] Assembler: support .int16/32/64 directives.
Wouter van Oortmerssen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 15:21:32 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364689: [WebAssembly] Assembler: support .int16/32/64 directives. (authored by aardappel, committed by ).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63959/new/
https://reviews.llvm.org/D63959
Files:
llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
llvm/trunk/test/MC/WebAssembly/basic-assembly.s
Index: llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
===================================================================
--- llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
+++ llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
@@ -665,13 +665,18 @@
return expect(AsmToken::EndOfStatement, "EOL");
}
- if (DirectiveID.getString() == ".int8") {
+ if (DirectiveID.getString() == ".int8" ||
+ DirectiveID.getString() == ".int16" ||
+ DirectiveID.getString() == ".int32" ||
+ DirectiveID.getString() == ".int64") {
if (CheckDataSection()) return true;
- int64_t V;
- if (Parser.parseAbsoluteExpression(V))
- return error("Cannot parse int8 constant: ", Lexer.getTok());
- // TODO: error if value doesn't fit?
- Out.EmitIntValue(static_cast<uint64_t>(V), 1);
+ const MCExpr *Val;
+ SMLoc End;
+ if (Parser.parseExpression(Val, End))
+ return error("Cannot parse .int expression: ", Lexer.getTok());
+ size_t NumBits = 0;
+ DirectiveID.getString().drop_front(4).getAsInteger(10, NumBits);
+ Out.EmitValue(Val, NumBits / 8, End);
return expect(AsmToken::EndOfStatement, "EOL");
}
Index: llvm/trunk/test/MC/WebAssembly/basic-assembly.s
===================================================================
--- llvm/trunk/test/MC/WebAssembly/basic-assembly.s
+++ llvm/trunk/test/MC/WebAssembly/basic-assembly.s
@@ -95,7 +95,10 @@
.L.str:
.int8 'H'
.asciz "ello, World!"
- .size .L.str, 14
+ .int16 1234
+ .int64 5000000000
+ .int32 2000000000
+ .size .L.str, 28
.ident "clang version 9.0.0 (trunk 364502) (llvm/trunk 364571)"
.globaltype __stack_pointer, i32
@@ -185,5 +188,8 @@
# CHECK-NEXT: .L.str:
# CHECK-NEXT: .int8 72
# CHECK-NEXT: .asciz "ello, World!"
+# CHECK-NEXT: .int16 1234
+# CHECK-NEXT: .int64 5000000000
+# CHECK-NEXT: .int32 2000000000
# CHECK: .globaltype __stack_pointer, i32
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63959.207157.patch
Type: text/x-patch
Size: 2124 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/9aa0c818/attachment-0001.bin>
More information about the llvm-commits
mailing list