[PATCH] D63957: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 14:30:31 PDT 2019
jsji created this revision.
jsji added reviewers: timshen, hfinkel, lebedev.ri, RKSimon.
Herald added subscribers: jfb, nemanjai.
Herald added a project: LLVM.
SCRUB_LOOP_COMMENT_RE was introduced in https://reviews.llvm.org/D31285
This works for some loops.
However, we may generate lines with loop comments only.
And since we don't scrum leading white spaces, this will leave an empty
line there, so FileCheck will complain it.
eg: llvm/test/CodeGen/PowerPC/PR35812-neg-cmpxchg.ll:27:15:
error: found empty check string with prefix 'CHECK:'
; CHECK-NEXT:
We should still keep the comment token there, so that we can safely
scrub the loop comment without breaking FileCheck.
Repository:
rL LLVM
https://reviews.llvm.org/D63957
Files:
llvm/test/CodeGen/PowerPC/PR35812-neg-cmpxchg.ll
llvm/utils/UpdateTestChecks/asm.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63957.207145.patch
Type: text/x-patch
Size: 6631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/c849238c/attachment.bin>
More information about the llvm-commits
mailing list