[PATCH] D63855: [ADCE] Fix for non-determistic uselists after dead block removal

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 14:29:34 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

Maybe worth explicitly mentioning in the commit message that AggressiveDeadCodeElimination::updateDeadRegions loops over BlocksWithDeadTerminators.

It's fine to commit non-determinism patches without a test, I think, because it's hard to write a useful regression test for these issues.  I mean, you could theoretically CHECK the use-list itself, but that isn't really productive.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63855/new/

https://reviews.llvm.org/D63855





More information about the llvm-commits mailing list