[PATCH] D63933: [NewGVN] Add unary FNeg support to NewGVN pass

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 13:14:45 PDT 2019


cameron.mcinally marked an inline comment as done.
cameron.mcinally added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/fpmath.ll:46
 ; CHECK: @test5(double %x)
-; CHECK: %neg1 = fneg double %x, !fpmath !0
-; CHECK: %neg2 = fneg double %x, !fpmath !1
-; CHECK: %foo = fadd double %neg1, %neg2
+; CHECK: %neg1 = fneg double %x, !fpmath !1
+; CHECK: %foo = fadd double %neg1, %neg1
----------------
fhahn wrote:
> Can you update the test to check !1 points to the expected metadata?
Sorry, missed this comment. Will submit a follow-up patch ASAP.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63933/new/

https://reviews.llvm.org/D63933





More information about the llvm-commits mailing list