[PATCH] D63947: [WebAssembly] Assembler: Improve section parsing.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: lib/MC/MCParser/WasmAsmParser.cpp:163
-    // one section per function, so they're optional to be specified with
-    // this directive.
     return false;
----------------
sbc100 wrote:
> Can you explain why this code is not needed and the commend isn't needed anymore?  
The section type parsing was actually duplicated code: the exact same thing is done by the StringSwitch above.

The "just ignore this section" is turned into an error, that was originally not an error just to get things going, but now I want to be more exact about our error checking and what we support.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63947/new/

https://reviews.llvm.org/D63947