[PATCH] D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed]

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

I am getting failures when trying to link these tests, due to missing symbols, e.g.:

cd projects/compiler-rt/lib/scudo/standalone/tests && ./bin/clang ScudoUnitTestsObjects.wrappers_c_test.cc.i386.o ScudoUnitTestsObjects.scudo_unit_test_main.cc.i386.o ScudoUnitTestsObjects.gtest-all.cc.i386.o lib/libRTScudoCUnitTest.i386.a -o projects/compiler-rt/lib/scudo/standalone/tests/./ScudoCUnitTest-i386-Test -Wl,-allow-shlib-undefined -lstdc++ -pthread -m32

lib/libRTScudoCUnitTest.i386.a(wrappers_c.cc.o): In function `scudo::atomic_u64::Type scudo::atomic_load<scudo::atomic_u64>(scudo::atomic_u64 const volatile*, scudo::memory_order)':
projects/compiler-rt/lib/scudo/standalone/atomic_helpers.h:66: undefined reference to `__atomic_load_8'
...

and other missing symbols.

It passes if I link manually and add in -latomic. Should that be added to the link flags somewhere? How does this work on the bots or elsewhere?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63831/new/

https://reviews.llvm.org/D63831