[PATCH] D63429: [DebugInfo] Avoid adding too much indirection to pointer-valued variables

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 207077.
jmorse added a comment.

Vedant wrote:

> This looks reasonable to me. Mind adding test coverage for simple tag_offset/fragment expressions?

Updated with two new variables / DBG_VALUEs to cover that -- as it turns out I was using the wrong kind of iterator in isComplex :(. Iterating elements seems to iterate over all expression storage, iterating over operands is what was needed. Great catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63429/new/

https://reviews.llvm.org/D63429

Files:
  include/llvm/IR/DebugInfoMetadata.h
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/IR/DebugInfoMetadata.cpp
  test/DebugInfo/MIR/X86/prolog-epilog-indirection.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63429.207077.patch
Type: text/x-patch
Size: 10259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/8d964c55/attachment.bin>