[PATCH] D49229: [AggressiveInstCombine] Fold redundant masking operations of shifted value

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 07:40:11 PDT 2019


lebedev.ri added a comment.

In D49229#1562329 <https://reviews.llvm.org/D49229#1562329>, @dnsampaio wrote:

> Hi @lebedev.ri,
>  Nice you looked this one as I am not quite sure what to do about it. Any suggestions?


As it can be seen from the disscussion here, while the problem this is trying to solve is real,
the actual solution that should be done is very much non-obvious. It kind-of doesn't anywhere.
Or maybe there's some astounding perf numbers (SPEC?) that justify **this** solution?
I don't have any further ideas presently, sorry. I only marked it to remove from review queue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49229/new/

https://reviews.llvm.org/D49229





More information about the llvm-commits mailing list