[PATCH] D63804: [PowerPC] Implement the areMemAccessesTriviallyDisjoint hook

[Jinsong Ji via Phabricator via llvm-commits]

jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM except for some minor comments update, you can update them before commit. 
Thanks for implementing this hook, it should improve scheduling in general.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:361
+
+  /// Return true if retrieve the base, offset from the base and width. Width
+  /// is the size of memory that is being loaded/stored (e.g. 1, 2, 4, 8).
----------------
This is a little confusing to me, it is easy to read it as `retrieve ... from ...`.
Maybe something like `get the base operand, byte offset of an instruction and the memory width`?

There are 2-3 similar ones in PPCInstrInfo.cpp as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63804/new/

https://reviews.llvm.org/D63804