[PATCH] D63925: [benchmark] Disable CMake get_git_version

[Andrew Ng via Phabricator via llvm-commits]

andrewng created this revision.
andrewng added reviewers: lebedev.ri, kbobyrev.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

Disabled CMake get_git_version as it is meaningless for this in-tree
build, and hardcoded a null version.

Not using get_git_version avoids a refresh of the git index that is
executed by get_git_version. Refreshing the index can take a
considerable amount of time if the index needs to be refreshed
(particularly with the mono repo). This situation can arise when
building shared source on a host in VMs.


https://reviews.llvm.org/D63925

Files:
  llvm/utils/benchmark/CMakeLists.txt
  llvm/utils/benchmark/README.LLVM


Index: llvm/utils/benchmark/README.LLVM
===================================================================
--- llvm/utils/benchmark/README.LLVM
+++ llvm/utils/benchmark/README.LLVM
@@ -21,3 +21,5 @@
   is applied to fix building with MinGW headers for ARM
 * https://github.com/google/benchmark/commit/a9b31c51b1ee7ec7b31438c647123c2cbac5d956
   is applied to disable exceptions in Microsoft STL when exceptions are disabled
+* Disabled CMake get_git_version as it is meaningless for this in-tree build,
+  and hardcoded a null version
Index: llvm/utils/benchmark/CMakeLists.txt
===================================================================
--- llvm/utils/benchmark/CMakeLists.txt
+++ llvm/utils/benchmark/CMakeLists.txt
@@ -76,8 +76,11 @@
 
 
 # Read the git tags to determine the project version
-include(GetGitVersion)
-get_git_version(GIT_VERSION)
+# WARNING: This is meaningless for when the benchmark library is being built in-tree,
+# so disable it and hardcode a null version.
+# include(GetGitVersion)
+# get_git_version(GIT_VERSION)
+set(GIT_VERSION "v0.0.0")
 
 # Tell the user what versions we are using
 string(REGEX MATCH "[0-9]+\\.[0-9]+\\.[0-9]+" VERSION ${GIT_VERSION})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63925.207030.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/851762da/attachment.bin>