[PATCH] D63905: Fix ASAN error caused by commit r364512

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 03:08:03 PDT 2019


rovka added a comment.

In D63905#1561649 <https://reviews.llvm.org/D63905#1561649>, @dblaikie wrote:

> Looks good to me, please commit
>
> (@rovka - this is at least a short-term fix, I'm approving this to unbreak LLVM's mainline - feel free to refix with other ideas if you have any (also happy to discuss this further with you here, IRC, or elsewhere on the mailing lists)


Thanks for looking into it and sorry about the breakage. I think one InVReg is sufficient, there's no need for a whole SmallVector there. What do you think about something like this <https://reviews.llvm.org/differential/diff/207020/>?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63905/new/

https://reviews.llvm.org/D63905





More information about the llvm-commits mailing list