[PATCH] D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: COFF/Writer.cpp:657
+void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) {
+  for (auto It : PartialSections) {
+    PartialSection *PSec = It.second;
----------------
mstorsjo wrote:
> ruiu wrote:
> > Use an actual type instead of `auto`.
> The type here is `std::map<PartialSectionKey, PartialSection *>::iterator`, so I think this is one of the cases where `auto` is warranted.
Ah, got it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63837/new/

https://reviews.llvm.org/D63837