[llvm] r364622 - [Support] Fix add fs::getUmask() patch
Alex Brachet via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 27 21:07:13 PDT 2019
Author: abrachet
Date: Thu Jun 27 21:07:13 2019
New Revision: 364622
URL: http://llvm.org/viewvc/llvm-project?rev=364622&view=rev
Log:
[Support] Fix add fs::getUmask() patch
Modified:
llvm/trunk/unittests/Support/Path.cpp
Modified: llvm/trunk/unittests/Support/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=364622&r1=364621&r2=364622&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/Path.cpp (original)
+++ llvm/trunk/unittests/Support/Path.cpp Thu Jun 27 21:07:13 2019
@@ -1534,7 +1534,7 @@ TEST_F(FileSystemTest, getUmask) {
unsigned CurrentMask = fs::getUmask();
EXPECT_EQ(CurrentMask, 0022U)
<< "getUmask() didn't return previously set umask()";
- EXPECT_EQ(::umask(OldMask), 0022) << "getUmask() may have changed umask()";
+ EXPECT_EQ(::umask(OldMask), 0022U) << "getUmask() may have changed umask()";
#endif
}
@@ -1556,7 +1556,7 @@ TEST_F(FileSystemTest, RespectUmask) {
ASSERT_NO_ERROR(fs::setPermissions(TempPath, AllRWE, /*RespectUmask=*/false));
- ErrorOr<fs::perms> Perms = fs::getPermissions(TempPath);
+ Perms = fs::getPermissions(TempPath);
ASSERT_TRUE(!!Perms);
EXPECT_EQ(Perms.get(), AllRWE) << "Should have ignored umask";
More information about the llvm-commits
mailing list