[PATCH] D63662: Changing CodeView Debug info Type record output

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: hans.
rnk added a comment.

+ at hans, this has been up for six days, but I haven't found time to do a deeper code review. Would you mind doing a round of review for Nilanjana?



================
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:183
+  uint64_t getStreamedLen() {
+    if(isStreaming())
+      return StreamedLen;
----------------
I would recommend using git-clang-format to fix formatting issues in just the parts of the code that your patch touches. If I'm not around, you should be able to ask Bob or Amy how to use this tool. It requires some git usage. There are other small formatting issues that need fixing, but I don't want to highlight them all.


================
Comment at: llvm/test/DebugInfo/COFF/types-basic.ll:515
+; ASM: .short	4611
+; ASM: .ascii	"\r\025\003\000t\000\000\000\000\000a\000\021\025\003\000\t\020\000\000A::f\000\363\362\361"
+; ASM: # FieldList (0x100A) {
----------------
Hm, we should do something about LF_FIELDLIST. The members should get directives. Maybe that's out of scope for this change. I think it's already an improvement.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63662/new/

https://reviews.llvm.org/D63662