[PATCH] D63469: hwasan: Teach the runtime to identify the local variable being accessed in UAR reports.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_report.cpp:165
+        // Calculate the offset from the object address to the faulting
+        // address. Because we only store the lower 20 bits of FP, the
+        // calculation is performed mod 2^20 and may harmlessly underflow if
----------------
eugenis wrote:
> > the lower 20 bits of FP
> Nit: they are not the lowest 20 bits. Add "significant" or something like that?
Reworded to `bits 4-19 of FP (bits 0-3 are guaranteed to be zero)`; should be a little clearer now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63469/new/

https://reviews.llvm.org/D63469