[PATCH] D63391: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 2)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 206940.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: kristina, dexonsmith.

Fix miscompile (it was even visible in already existing tests!!!) by properly calculating the constant for new comparison.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63391/new/

https://reviews.llvm.org/D63391

Files:
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  lib/Support/APInt.cpp
  test/CodeGen/AArch64/urem-seteq-optsize.ll
  test/CodeGen/AArch64/urem-seteq-vec-nonsplat.ll
  test/CodeGen/AArch64/urem-seteq-vec-splat.ll
  test/CodeGen/AArch64/urem-seteq.ll
  test/CodeGen/X86/jump_sign.ll
  test/CodeGen/X86/omit-urem-of-power-of-two-or-zero-when-comparing-with-zero.ll
  test/CodeGen/X86/urem-seteq-optsize.ll
  test/CodeGen/X86/urem-seteq-vec-nonsplat.ll
  test/CodeGen/X86/urem-seteq-vec-splat.ll
  test/CodeGen/X86/urem-seteq.ll
  unittests/ADT/APIntTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63391.206940.patch
Type: text/x-patch
Size: 38908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190627/ef386358/attachment-0001.bin>