[PATCH] D63899: [Bitcode] Move Bitstream to a separate library

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 14:37:34 PDT 2019


thegameg created this revision.
thegameg added reviewers: jfb, dblaikie, pcc.
Herald added subscribers: arphaman, dexonsmith, hiraditya, mgorny.
Herald added a project: LLVM.

This moves Bitcode/Bitstream*, Bitcode/BitCodes.h to Bitstream/.

This is needed to avoid a circular dependency when using the bitstream code for parsing optimization remarks.

Since Bitcode uses Core for the IR part:

libLLVMRemarks -> Bitcode -> Core

and Core uses libLLVMRemarks to generate remarks (see IR/RemarkStreamer.cpp):

Core -> libLLVMRemarks

we need to separate the Bitstream and Bitcode part.

For clang-doc, it seems that it doesn't need the whole bitcode layer, so I updated the CMake to only use the bitstream part.


https://reviews.llvm.org/D63899

Files:
  clang-tools-extra/clang-doc/BitcodeReader.h
  clang-tools-extra/clang-doc/BitcodeWriter.h
  clang-tools-extra/clang-doc/CMakeLists.txt
  clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp
  clang-tools-extra/unittests/clang-doc/CMakeLists.txt
  clang/include/clang/Frontend/SerializedDiagnosticPrinter.h
  clang/include/clang/Frontend/SerializedDiagnosticReader.h
  clang/include/clang/Frontend/SerializedDiagnostics.h
  clang/include/clang/Serialization/ASTBitCodes.h
  clang/include/clang/Serialization/ASTReader.h
  clang/include/clang/Serialization/ASTWriter.h
  clang/include/clang/Serialization/Module.h
  clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  clang/lib/Frontend/ASTUnit.cpp
  clang/lib/Frontend/SerializedDiagnosticReader.cpp
  clang/lib/Frontend/TestModuleFileExtension.cpp
  clang/lib/Frontend/TestModuleFileExtension.h
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTReaderDecl.cpp
  clang/lib/Serialization/ASTReaderStmt.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/lib/Serialization/ASTWriterDecl.cpp
  clang/lib/Serialization/ASTWriterStmt.cpp
  clang/lib/Serialization/GeneratePCH.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp
  clang/lib/Serialization/PCHContainerOperations.cpp
  clang/tools/libclang/CXLoadedDiagnostic.cpp
  llvm/include/llvm/Bitcode/BitCodes.h
  llvm/include/llvm/Bitcode/BitcodeReader.h
  llvm/include/llvm/Bitcode/BitstreamReader.h
  llvm/include/llvm/Bitcode/BitstreamWriter.h
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/Bitstream/BitCodes.h
  llvm/include/llvm/Bitstream/BitstreamReader.h
  llvm/include/llvm/Bitstream/BitstreamWriter.h
  llvm/include/llvm/Support/JSON.h
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/BitstreamReader.cpp
  llvm/lib/Bitcode/Reader/CMakeLists.txt
  llvm/lib/Bitcode/Reader/LLVMBuild.txt
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/Bitstream/CMakeLists.txt
  llvm/lib/Bitstream/LLVMBuild.txt
  llvm/lib/Bitstream/Reader/BitstreamReader.cpp
  llvm/lib/Bitstream/Reader/CMakeLists.txt
  llvm/lib/Bitstream/Reader/LLVMBuild.txt
  llvm/lib/CMakeLists.txt
  llvm/lib/LLVMBuild.txt
  llvm/tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
  llvm/unittests/Bitcode/BitstreamReaderTest.cpp
  llvm/unittests/Bitcode/BitstreamWriterTest.cpp
  llvm/unittests/Bitcode/CMakeLists.txt
  llvm/unittests/Bitstream/BitstreamReaderTest.cpp
  llvm/unittests/Bitstream/BitstreamWriterTest.cpp
  llvm/unittests/Bitstream/CMakeLists.txt
  llvm/unittests/CMakeLists.txt
  llvm/utils/GenLibDeps.pl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63899.206930.patch
Type: text/x-patch
Size: 28051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190627/20e83beb/attachment.bin>


More information about the llvm-commits mailing list